Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent automatic start of Jamulus after installation on windows when no audio driver available #2099

Closed
henkdegroot opened this issue Oct 30, 2021 · 7 comments · Fixed by #2103
Assignees
Milestone

Comments

@henkdegroot
Copy link
Contributor

henkdegroot commented Oct 30, 2021

Has this feature been discussed and generally agreed?
Enhancement has been mentioned in #2088

Describe the solution you'd like
The last screen of the windows installer contains an option to automatically start Jamulus after the installation completed.
This option is enabled by default and can be disabled by the user (if not desired to start).
The installer allows you to install Jamulus on a system which does not have a audio driver (asio or jack) installed. In this scenario is does not make sense to automatically start Jamulus after the installation completed, as it will fail due to the missing audio driver.

This enhancement applies to the windows installer only and will set the option to automatically start Jamulus after the installation to unchecked when there was no audio driver detected and the user decided to go ahead with the installation.

@henkdegroot
Copy link
Contributor Author

@gilgongo , can you assign this to me please?

@henkdegroot
Copy link
Contributor Author

@gilgongo, actually do you think there will ever be a scenario that you want to auto start if you don't have a correct driver installed during installation?
As if not, we could just remove the auto start option completely for this scenario.
Leaving it there of course when there is a driver detected.

@gilgongo
Copy link
Member

Yes that would seem potentially less confusing as we know that starting the client won't work when there is a problem with the driver. I suppose it's just possible that the subsequent errors encountered might give you some clues if it wasn't immediately obvious why you had a problem perhaps? But that seems unlikely.

@ann0see
Copy link
Member

ann0see commented Nov 3, 2021

@henkdegroot I'd suggest you to read through #841 to get a few insights in the installer.

@gilgongo
Copy link
Member

gilgongo commented Nov 7, 2021

Is this also related @henkdegroot ? Maybe look at it in the same PR? #1756

@henkdegroot
Copy link
Contributor Author

@gilgongo, it is partial related. As the dialog in #1756 is the dialog which will be presented when Jamulus run automatically after the install (without having an ASIO driver present). However #1756 is more about "later". I.e. I may have removed the ASIO driver from my system (or it is not working anymore) and then when I start Jamulus I get this error message.

Perhaps adding a link in that dialog referring to the installation for windows page on jamulus.io would be nice?

@gilgongo
Copy link
Member

gilgongo commented Nov 7, 2021

Perhaps adding a link in that dialog referring to the installation for windows page on jamulus.io would be nice?

Yes, always good to have some "further info" available for when things don't go as expected.

@henkdegroot henkdegroot changed the title Disable automatic start of Jamulus after installation on windows when no audio driver available Prevent automatic start of Jamulus after installation on windows when no audio driver available Dec 5, 2021
@pljones pljones added this to the Release 3.8.2 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants