Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Improve country code conversion failure modes #2845

Open
hoffie opened this issue Sep 9, 2022 · 2 comments
Open

Refactor: Improve country code conversion failure modes #2845

hoffie opened this issue Sep 9, 2022 · 2 comments
Assignees
@hoffie
Labels
refactoring Non-behavioural changes, Code cleanup

Comments

@hoffie
Copy link
Member

hoffie commented Sep 9, 2022

I'd rather "convert to wireformat" and "convert from wireformat" were both "safe" - i.e. returned "Error" (e.g. -1) or a valid response, given any integer value, then have the caller deal with the error as it sees fit. Having to "know" about the IsCountryCodeSupported on top of the conversion methods seems excessively complicated.

Originally posted by @pljones in #2829 (comment)
@hoffie hoffie self-assigned this Sep 9, 2022
@hoffie hoffie added this to the Release 3.10.0 milestone Sep 9, 2022
This was referenced Sep 9, 2022
Merged
Merged
@ann0see ann0see added the refactoring Non-behavioural changes, Code cleanup label Oct 17, 2022
@pljones
Copy link
Collaborator

pljones commented Apr 19, 2023

@hoffie is this likely to get a PR?

@pljones
Copy link
Collaborator

pljones commented Jun 25, 2023

Dropping from 3.10.0.

@pljones pljones removed this from the Release 3.10.0 milestone Jun 25, 2023
@pljones pljones added this to Tracking Jun 25, 2023
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoffie hoffie

Labels
refactoring Non-behavioural changes, Code cleanup
Projects
Tracking
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hoffie @pljones @ann0see