Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store recorder settings #313

Closed
pljones opened this issue May 31, 2020 · 6 comments
Closed

Store recorder settings #313

pljones opened this issue May 31, 2020 · 6 comments
Labels
feature request Feature request

Comments

@pljones
Copy link
Collaborator

pljones commented May 31, 2020

Just to avoid cluttering #228 with any more bits...

The last "Enable recording" state and the recording directory - now they exist / are on the UI - should be stored in the server settings.

Depends on me finishing #228, of course :).

@pljones
Copy link
Collaborator Author

pljones commented Jul 6, 2020

Aha, now I guess I need to pick this up.
@pljones Maybe this makes it appear in my issue highlights?

@corrados
Copy link
Contributor

corrados commented Jul 6, 2020

As I am in a progress of revising the settings implementation, we may get a lot of merge problems if you start right now. Maybe it is wise to wait for some days until my implementation has settled a bit.

@pljones
Copy link
Collaborator Author

pljones commented Jul 6, 2020

Ah yes, good point. There are a few settings-related Issues still open, I'll see if there are any unrelated ones I was thinking of. (Even the auto-update touches settings as it has settings to store.)

@pljones
Copy link
Collaborator Author

pljones commented Jul 31, 2020

OK, I might pick this up next if things have stabilised.

@corrados
Copy link
Contributor

corrados commented Aug 1, 2020

Yes, go ahead. I'm done for now with my changes in the settings.

@pljones
Copy link
Collaborator Author

pljones commented Aug 11, 2020

Just to tag #513 as the branch for this (in case anyone else is watching).

In fact, I'll close this and leave things to the PR to resolve.

@pljones pljones closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants