Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Consistent Qt style for ifdef #3380

Open
ann0see opened this issue Sep 22, 2024 · 2 comments
Open

Use Consistent Qt style for ifdef #3380

ann0see opened this issue Sep 22, 2024 · 2 comments
Labels
refactoring Non-behavioural changes, Code cleanup

Comments

@ann0see
Copy link
Member

ann0see commented Sep 22, 2024

Are the Windows and Android ones okay? Is the Q_ a "Qt" thing that we can use for all platforms? What's the OT_ thing?

Originally posted by @pljones in #3360 (comment)

The code should be refactored such that only one style is used. Probably Q_OS_WIN: https://doc.qt.io/qt-5/qtglobal.html#Q_OS_WIN

@ann0see ann0see added the refactoring Non-behavioural changes, Code cleanup label Sep 22, 2024
@softins
Copy link
Member

softins commented Sep 22, 2024

The OT_ thing is just an enum within the Jamulus code, for the protocol byte that indicates the OS type:

jamulus/src/util.h

Lines 1062 to 1074 in d6c6fc7

class COSUtil
{
public:
enum EOpSystemType
{
// used for protocol -> enum values must be fixed!
OT_WINDOWS = 0,
OT_MAC_OS = 1,
OT_LINUX = 2,
OT_ANDROID = 3,
OT_I_OS = 4,
OT_UNIX = 5
};

@ann0see
Copy link
Member Author

ann0see commented Sep 22, 2024

Yes, I commented that in the respective PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Non-behavioural changes, Code cleanup
Projects
None yet
Development

No branches or pull requests

2 participants