New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite cclientdlg closeEvent, onAboutToQuit, ... #3402

Open

ann0see opened this issue Oct 8, 2024 · 0 comments

Labels

Member

ann0see commented Oct 8, 2024 •

edited

Loading

There was a lot of discussion on closing methods in cclientdlg in #3372 This should probably be refactored.

Maybe closeEvent should just call QCoreApplication::instance()->exit(); and then do the work in OnAboutToQuit handlers? That should stop needing to call XYZ.Stop().

Of course, if that's what the "default implementation of this event handler routine" does, it would move all the code here into ClientDlg.OnAboutToQuit (plus handlers in each called class).

Originally posted by @pljones in #3372 (comment), #3372 (comment), #3372 (comment)

The text was updated successfully, but these errors were encountered:

ann0see mentioned this issue

Refactor Connect and Disconnect functionality out to CClient #3372

Open

5 tasks

ann0see changed the title ~~Rewrite cclientdlg closeEvent~~ Rewrite cclientdlg closeEvent, onAboutToQuit, ...

ann0see added the refactoring label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment