Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack_signed_32_big_endian (and other omissions) #33

Open
pippijn opened this issue Jan 27, 2015 · 1 comment
Open

pack_signed_32_big_endian (and other omissions) #33

pippijn opened this issue Jan 27, 2015 · 1 comment
Labels
enhancement forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@pippijn
Copy link

pippijn commented Jan 27, 2015

There are a number of functions missing from Binary_packing. E.g. I have to do pack_signed_32 ~byte_order:Big_endian`, which the documentation suggests is up to 3 times slower than a 32 bit _big_endian function. Given that there is a pack_signed_64_big_endian, I see no reason why there shouldn't be one for 32 bit. I'm aware that there is a pack_unsigned_32_int_big_endian (I want unsigned, but for fixed width 32 bit, signed works as well), but I'd like to be portable to 32 bit platforms, where int is signed 31 bit.

@ghost
Copy link

ghost commented Jan 27, 2015

Seems reasonable to add these. I'll schedule a patch for the next release.

@ghost ghost self-assigned this Jan 27, 2015
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

3 participants