Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5.3 support #12

Closed
kit-ty-kate opened this issue Oct 10, 2024 · 1 comment
Closed

OCaml 5.3 support #12

kit-ty-kate opened this issue Oct 10, 2024 · 1 comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@kit-ty-kate
Copy link

kit-ty-kate commented Oct 10, 2024

Using the latest release of ppxlib_jane v0.17.1 (upgrading to OCaml 5.3), ppx_bin_prot fails with:

#=== ERROR while compiling ppx_bin_prot.v0.17.0 ===============================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/ppx_bin_prot.v0.17.0
# command              ~/.opam/5.3/bin/dune build -p ppx_bin_prot -j 1
# exit-code            1
# env-file             ~/.opam/log/ppx_bin_prot-19-a3be7b.env
# output-file          ~/.opam/log/ppx_bin_prot-19-a3be7b.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlopt.opt -w -40 -g -I src/.ppx_bin_prot.objs/byte -I src/.ppx_bin_prot.objs/native -I /home/opam/.opam/5.3/lib/base -I /home/opam/.opam/5.3/lib/base/base_internalhash_types -I /home/opam/.opam/5.3/lib/base/shadow_stdlib -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.3/lib/ppx_derivers -I /home/opam/.opam/5.3/lib/ppx_here/expander -I /home/opam/.opam/5.3/lib/ppxlib -I /home/opam/.opam/5.3/lib/ppxlib/ast -I /home/opam/.opam/5.3/lib/ppxlib/astlib -I /home/opam/.opam/5.3/lib/ppxlib/print_diff -I /home/opam/.opam/5.3/lib/ppxlib/stdppx -I /home/opam/.opam/5.3/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3/lib/ppxlib_jane -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/stdlib-shims -I shape/src/.bin_shape_expand.objs/byte -I shape/src/.bin_shape_expand.objs/native -intf-suffix .ml -no-alias-deps -o src/.ppx_bin_prot.objs/native/ppx_bin_prot.cmx -c -impl src/ppx_bin_prot.pp.ml)
# File "src/ppx_bin_prot.ml", line 12, characters 11-47:
# 12 |   type t = Ppxlib_jane.Ast_builder.Default.mode option
#                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound type constructor "Ppxlib_jane.Ast_builder.Default.mode"
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I src/.ppx_bin_prot.objs/byte -I /home/opam/.opam/5.3/lib/base -I /home/opam/.opam/5.3/lib/base/base_internalhash_types -I /home/opam/.opam/5.3/lib/base/shadow_stdlib -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.3/lib/ppx_derivers -I /home/opam/.opam/5.3/lib/ppx_here/expander -I /home/opam/.opam/5.3/lib/ppxlib -I /home/opam/.opam/5.3/lib/ppxlib/ast -I /home/opam/.opam/5.3/lib/ppxlib/astlib -I /home/opam/.opam/5.3/lib/ppxlib/print_diff -I /home/opam/.opam/5.3/lib/ppxlib/stdppx -I /home/opam/.opam/5.3/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3/lib/ppxlib_jane -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/stdlib-shims -I shape/src/.bin_shape_expand.objs/byte -intf-suffix .ml -no-alias-deps -o src/.ppx_bin_prot.objs/byte/ppx_bin_prot.cmo -c -impl src/ppx_bin_prot.pp.ml)
# File "src/ppx_bin_prot.ml", line 12, characters 11-47:
# 12 |   type t = Ppxlib_jane.Ast_builder.Default.mode option
#                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound type constructor "Ppxlib_jane.Ast_builder.Default.mode"
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Oct 11, 2024
@kit-ty-kate
Copy link
Author

was fixed in ppxlib_jane.v0.17.2

@kit-ty-kate kit-ty-kate closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

2 participants