-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub syntax highlighting to *.janet files #433
Comments
There are already syntax highlighting files and an unmerged linguist PR, I’m closing this for now. The git attributes file was previously removed as I don’t think it is that important. |
@bakpakin They closed that PR: github-linguist/linguist#4674 Syntax highlighting helps those of us new to Janet read the code examples and makes Janet feel more "legit", but obviously it's up to you. |
@elimisteve I believe others (including me!) would also like appropriate highlighting. As you saw in that issue though, for whatever reason(s) the last attempt was not met favorably. There was some discussion on the gitter channel about this topic and I believe one of the opinions that had some traction was to keep growing the various numbers until a subsequent attempt is made (or something like that). FWIW, I think @katafrakt made this: https://isjanetthereyet.herokuapp.com/ (Note that one of the entities that is influencing how "legit" something "feels" is none other than our hosts...) |
clojure syntax highlighting falls flat for many real janet examples, they syntax have differences, so I would rather have none or a correct one. |
I tried Scheme too and it didn't help much at all, but using Clojure's syntax highlighting looks pretty fantastic to me: https://github.com/elimisteve/janet/blob/master/examples/life.janet |
This isn't in our power to make. GitHub has to accept the Linguist PR and they won't do that until there are more repos. |
On a side note, it seems possible that if Janet support were added to Rouge, syntax highlighting might get working sooner at gitlab: https://docs.gitlab.com/ee/user/project/highlighting.html ...and there's already a lexer for Clojure. |
FYI, after consulting with pyrmont, I've started a rouge lexer for Janet based on the Clojure one: https://github.com/sogaiu/rouge/tree/janet |
Thanks to @pyrmont's improvements and fixes, Rouge may gain support for Janet in its next release: rouge-ruby/rouge#1558 (comment)
|
Looks like this may be the easiest way to do that: https://github.com/github/linguist#using-gitattributes
The text was updated successfully, but these errors were encountered: