Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cortex pull author/model_id && cortex pull model_id returns "Model not found" #1263

Closed
2 of 6 tasks
gabrielle-ong opened this issue Sep 19, 2024 · 5 comments
Closed
2 of 6 tasks
Assignees
Labels
P0: critical Mission critical type: bug Something isn't working
Milestone

Comments

@gabrielle-ong
Copy link
Contributor

Cortex version

0.5.0-68 (actually 67)

Describe the Bug

From #1239:
When pulling a model from HF /<model_name>, I expect to display its variant options and allow user to select.

Pull directly from HF url is successful

Steps to Reproduce

cortex-nightly pull TheBloke/Mistral-7B-Instruct-v0.1-GGUF
cortex-nightly pull cortexso/codestral

Screenshots / Logs

Errors for HR author/model_name:
image

Successful when direct HF URL:
image

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@gabrielle-ong gabrielle-ong added the type: bug Something isn't working label Sep 19, 2024
@0xSage 0xSage added the P0: critical Mission critical label Sep 19, 2024
@0xSage 0xSage added this to the v0.1.0 milestone Sep 19, 2024
@0xSage
Copy link
Contributor

0xSage commented Sep 19, 2024

Also didnt work for me:

cortex pull:
❌ model_id
❌ repo_id/model_id
✅ full .gguf url

❯ sudo cortex-nightly pull llama3.1
Validating download items, please wait..
Found invalid download item: https://huggingface.co/cortexso/llama3.1/resolve/main/model.gguf - CURL failed: Couldn't resolve host name
CURL failed: Couldn't resolve host name

A new release of cortex is available: v0.5.0-68 -> v0.5.0-70
To upgrade, run: cortex-nightly update
❯ sudo cortex-nightly pull cortexso/llama3.1
Model not found

A new release of cortex is available: v0.5.0-68 -> v0.5.0-70
To upgrade, run: cortex-nightly update

@0xSage 0xSage changed the title bug: Cortex pull from HF author/model_name returns "Model not found" bug: cortex pull author/model_id && cortex pull model_id returns "Model not found" Sep 19, 2024
@namchuai
Copy link
Contributor

@gabrielle-ong @0xSage , I think please update cortex to latest. The version you test might be before my PR being merged.
Screenshot 2024-09-20 at 14 57 50

Screenshot 2024-09-20 at 14 58 44

@namchuai
Copy link
Contributor

Even with model id only from cortexso, it should work. I can only think that your version haven't included my PR yet.

Screenshot 2024-09-20 at 15 19 27

@gabrielle-ong
Copy link
Contributor Author

Thanks James! You're right, works well on v-74 for me.
@0xSage feel free to verify then close issue

@0xSage
Copy link
Contributor

0xSage commented Sep 21, 2024

Verified, nicely done!

@0xSage 0xSage closed this as completed Sep 21, 2024
@github-project-automation github-project-automation bot moved this to Completed in Jan & Cortex Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants