Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: when do we write into /logs? #1265

Closed
0xSage opened this issue Sep 19, 2024 · 4 comments
Closed

question: when do we write into /logs? #1265

0xSage opened this issue Sep 19, 2024 · 4 comments
Assignees

Comments

@0xSage
Copy link
Contributor

0xSage commented Sep 19, 2024

Dumb question: when does cortex actually write into /logs?

v70

I ran the following commands:

  • cortex update
  • cortex engines uninstall
  • cortex engines install

No logs. For some reason, I expected some of these commands to start logging into /logs.

Only server commands made it to logs:

  • cortex start
  • cortex stop

Question

  1. Are logs only meant to capture usage activity during server mode?
  2. If something goes wrong during engine install, model download, it's not logged?
@0xSage 0xSage added the type: bug Something isn't working label Sep 19, 2024
@0xSage 0xSage closed this as completed Sep 19, 2024
@0xSage 0xSage reopened this Sep 19, 2024
@0xSage 0xSage changed the title bug: [DESCRIPTION] question: when do we write into /logs? Sep 19, 2024
@0xSage 0xSage added type: question and removed type: bug Something isn't working labels Sep 19, 2024
@0xSage
Copy link
Contributor Author

0xSage commented Sep 19, 2024

Ok half way through usage, I see cortex-cli.log, but it doesn't actually output CLI logs. What is this file for?

@nguyenhoangthuan99
Copy link
Contributor

nguyenhoangthuan99 commented Sep 23, 2024

Currently, due to this ticket #1153, we cannot write log from 2 different processes into 1 log file, so we decided to separate the log into 2 file

  • cortex.log write log from server's process
  • cortex-cli.log write log from CLI's process.

cortex-cli.log is used to output more information when using CLI, and help debug easier.

@0xSage
Copy link
Contributor Author

0xSage commented Sep 26, 2024

@nguyenhoangthuan99 Ah cool , maybe better naming to make delineation clearer?
cortex-server.log

@0xSage
Copy link
Contributor Author

0xSage commented Sep 30, 2024

Closing this as won't do. But we need to document this @gabrielle-ong
ppl will be confused about the difference btw the two logs

@0xSage 0xSage closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@nguyenhoangthuan99 @0xSage and others