Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cortex pull https://huggingface.co/cortexso/mistral doesnt work & has buggy logs #1269

Closed
freelerobot opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
category: model management Model pull, yaml, model state type: bug Something isn't working
Milestone

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Sep 19, 2024

  1. cortex pull https://huggingface.co/cortexso/mistral/blob/main/model.gguf works beautifully
  2. cortex pull https://huggingface.co/cortexso/mistral/ doesn't work.
❯ sudo cortex-nightly pull https://huggingface.co/cortexso/mistral
Password:
Validating download items, please wait..
Start downloading: mistral
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 73738  100 73738    0     0   155k      0 --:--:-- --:--:-- --:--:--  155k
Model mistral downloaded successfully!
Not a valid GGUF file
  1. Should we also support the main repo url?
    Reasons:
  • Users are unlikely to grab the .gguf url
  • Most users will paste in the main model repo URL, and expect us to use the .gguf in the main branch
  • I could be wrong here, but implementation wise: cortex pull HF_URL/cortexso/mistral is similar to cortex pull cortexso/mistral
  1. Small stdout bug here:
    Model mistral downloaded successfully!
    Not a valid GGUF file
@freelerobot freelerobot added the category: model management Model pull, yaml, model state label Sep 19, 2024
@freelerobot freelerobot moved this to Need Investigation in Menlo Sep 19, 2024
@freelerobot freelerobot changed the title question: Should partial URL work cortex pull https://huggingface.co/cortexso/mistral ? question: Should HF Repo URL work: cortex pull https://huggingface.co/cortexso/mistral ? Sep 19, 2024
@freelerobot freelerobot changed the title question: Should HF Repo URL work: cortex pull https://huggingface.co/cortexso/mistral ? question: Should this work? cortex pull https://huggingface.co/cortexso/mistral Sep 19, 2024
@freelerobot freelerobot changed the title question: Should this work? cortex pull https://huggingface.co/cortexso/mistral bug: cortex pull https://huggingface.co/cortexso/mistral Sep 19, 2024
@freelerobot freelerobot added the type: bug Something isn't working label Sep 19, 2024
@freelerobot freelerobot changed the title bug: cortex pull https://huggingface.co/cortexso/mistral bug: cortex pull https://huggingface.co/cortexso/mistral doesnt work & has buggy logs Sep 19, 2024
@freelerobot
Copy link
Contributor Author

QA'd and working 🙏. Closing.

@github-project-automation github-project-automation bot moved this from In Progress to Review + QA in Menlo Sep 30, 2024
@freelerobot freelerobot moved this from Review + QA to Completed in Menlo Sep 30, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model management Model pull, yaml, model state type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants