Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requests and response body to log in DEBUG mode #1323

Closed
nguyenhoangthuan99 opened this issue Sep 24, 2024 · 4 comments · Fixed by #1636
Closed

Add requests and response body to log in DEBUG mode #1323

nguyenhoangthuan99 opened this issue Sep 24, 2024 · 4 comments · Fixed by #1636
Assignees
Milestone

Comments

@nguyenhoangthuan99
Copy link
Contributor

No description provided.

@nguyenhoangthuan99 nguyenhoangthuan99 self-assigned this Sep 24, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 moved this to In Progress in Jan & Cortex Oct 4, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 moved this from In Progress to Investigating in Jan & Cortex Oct 4, 2024
@0xSage 0xSage moved this from Investigating to Planning in Jan & Cortex Oct 15, 2024
@dan-homebrew
Copy link
Contributor

@nguyenhoangthuan99 Is this task still necessary?

@dan-homebrew dan-homebrew moved this from Planning to Investigating in Jan & Cortex Oct 31, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 moved this from Investigating to In Progress in Jan & Cortex Nov 5, 2024
@nguyenhoangthuan99
Copy link
Contributor Author

  • We need to add log request and response body with DEBUG log level.
  • We need to support set loglevel when start cortex server:
    • cortex start --loglevel DEBUG.
    • List of accepted loglevel is: TRACE, DEBUG, INFO, WARNING, ERROR

@gabrielle-ong
Copy link
Contributor

Thanks @nguyenhoangthuan99 for the note:
ERROR > WARN > INFO > DEBUG > TRACE. for example if you set log level is INFO you'll only see ERROR, WARN, and INFO

On Mac, I'm still getting INFO logs despite setting WARN loglevel.

cortex stop
cortex start --loglevel WARN
cortex run tinyllama:1b-gguf

Here's the new log files (after deleting)
cortex-cli.log
cortex.log

@gabrielle-ong
Copy link
Contributor

@vansangpfiev thanks for fixing!
✅ QA: The correct priority of log levels appear for Mac: ERROR > WARN > INFO > DEBUG > TRACE

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Jan & Cortex Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants