Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Could not able to run models since 172 #1505

Closed
2 of 6 tasks
louis-menlo opened this issue Oct 16, 2024 · 4 comments
Closed
2 of 6 tasks

bug: Could not able to run models since 172 #1505

louis-menlo opened this issue Oct 16, 2024 · 4 comments
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@louis-menlo
Copy link
Contributor

louis-menlo commented Oct 16, 2024

Cortex version

172-176

Describe the Bug

Model run is broken at 172; I was unable to start HF model models.
It worked fine before.

https://huggingface.co/bartowski/Llama-3.2-1B-Instruct-GGUF/resolve/main/Llama-3.2-1B-Instruct-Q8_0.gguf

Steps to Reproduce

  1. Update to version 172 or the latest version 176.
  2. Clean.
  3. Pull a HF model
  4. Run
  5. See errors.

Screenshots / Logs

image
image

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@nguyenhoangthuan99
Copy link
Contributor

This issue has been resolved by this pr #1507

@gabrielle-ong gabrielle-ong moved this from Investigating to Review + QA in Menlo Oct 17, 2024
@gabrielle-ong
Copy link
Contributor

@nguyenhoangthuan99 / @vansangpfiev for v183,

  • I'm getting the same error as Louis' first picture
  • For huggingface models only (cortexso models are ok)
  • cortex run <Model ID> is successful but cortex run <model alias> throws the uncaught exception YAML::BadSubscript

Imagecortex-cli.log
cortex.log

@vansangpfiev
Copy link
Contributor

Hi @gabrielle-ong, we will deprecate model_alias soon #1410 (comment). So can we mark this bug as won't fix?

@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Oct 18, 2024

True agree, thanks @vansangpfiev
This will be handled as part of #1512 next week

  • deprecating model_alias
  • using regex for cortex run, so this error should not occur

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 18, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.1 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants