-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pytest for e2e testing #1188
Conversation
358d751
to
f3dc114
Compare
f3dc114
to
67a7b2e
Compare
67a7b2e
to
081b635
Compare
@namchuai I think this is a great start, but I'd like to push our testing strategy to be more rigorous:
Also: can I check my understanding:
|
ce1b575
to
f6bc323
Compare
I did put: IMO, end to end testing is based on user's perspective. It ensure that whatever we changes or update in the future, the feature still works. And it will include mostly stdout and stderr validation.
I think we can separate it into 2 parts: With this, we can mock and write unit test the Part 1 is more complicated and involves:
For this, I think we can write an e2e test for |
f6bc323
to
2b0983d
Compare
@namchuai Got it - thank you for thinking through this very clearly. Approved and fingers crossed that these new e2e tests will help us catch bugs before it goes out to users 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for driving this 🙏
Signed-off-by: James <namnh0122@gmail.com>
2b0983d
to
505d727
Compare
Describe Your Changes
Items
How to use
engine/build/cortex-cpp
pip install pytest requests
2.1. On windows, I have to use
pip install pytest requests --user
python e2e-test/main.py
Remaining things to do
Screenshots
windows
Sample output
Fixes Issues
Self Checklist