Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Jan Quick ask (system tray instance) blocks app update autorestarts #2308

Closed
Van-QA opened this issue Mar 11, 2024 · 6 comments
Closed
Assignees
Labels
category: accessibility Accessibility and shortcuts P2: nice to have Nice to have feature type: bug Something isn't working

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Mar 11, 2024

Describe the bug
The system tray instance of Jan is blocking the auto restart after an update.

Steps to reproduce

  1. Trigger an update for Jan.
  2. Wait for the update to download and install.
  3. Observe that Jan prompts for a restart.
  4. Attempt to restart Jan using the provided option.
  5. Notice that the system tray instance of Jan prevents the auto restart from completing.

Expected behavior
After an update, Jan should automatically restart without interference from the system tray instance.

Environment details

  • Operating System: Windows 11 / Mac

Additional context
The interference from the system tray instance may prevent timely application of updates and pose potential security risks due to outdated software.

@Van-QA Van-QA added the type: bug Something isn't working label Mar 11, 2024
@Van-QA Van-QA added this to the v0.4.9 milestone Mar 11, 2024
@louis-jan louis-jan moved this to In Review in Menlo Mar 11, 2024
@Van-QA
Copy link
Contributor Author

Van-QA commented Mar 19, 2024

Closing this issue for now with a temporally fix by adding it to exp feat ✅
We will following up on the issue using #2356

@Van-QA Van-QA closed this as completed Mar 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Menlo Mar 19, 2024
@Van-QA Van-QA reopened this May 31, 2024
@Van-QA
Copy link
Contributor Author

Van-QA commented May 31, 2024

To repro:
Mac m1, v0.4.14-459
Quit the app, open the app
Click upgrade
App quits, and sometimes it just doesn't restart.
If it does restart, or if I manually reopen the app, it is still on the old version.

2/3 times I have to manually download the app binary again

The issue is:
When quick ask is turned on
The app never really quits
So a restart is not possible, users are stuck in a loop.

image

Quoted from Nic 🙏
Users will have to manually close the Jan from both Tray and Dock before the update

@Van-QA Van-QA modified the milestones: v0.4.9, v0.6.0 📜 May 31, 2024
@Van-QA Van-QA moved this from Done to Icebox in Menlo May 31, 2024
@louis-jan
Copy link
Contributor

Is that still a relevant issue? @Van-QA

@Van-QA
Copy link
Contributor Author

Van-QA commented Aug 28, 2024

The issue persists and continues to block auto-updates when users have them turned ON. While it may not occur in all cases, it remains unstable.

@imtuyethan imtuyethan moved this from Icebox to Need Investigation in Menlo Sep 2, 2024
@imtuyethan imtuyethan removed this from the v0.X.0 📜 milestone Sep 2, 2024
@freelerobot freelerobot added P1: important Important feature / fix and removed P1: important Important feature / fix labels Sep 5, 2024
@freelerobot freelerobot changed the title bug: Quick ask - system tray instance of Jan is blocking the auto restart after update bug: Jan Quick ask (system tray instance) blocks app update autorestarts Sep 5, 2024
@freelerobot freelerobot added the P2: nice to have Nice to have feature label Sep 5, 2024
@freelerobot
Copy link
Contributor

P2 since not many users actually use quick ask - and we may eventually build it differently

@freelerobot freelerobot moved this from Need Investigation to Icebox in Menlo Sep 5, 2024
@freelerobot freelerobot added the category: accessibility Accessibility and shortcuts label Oct 14, 2024
@imtuyethan
Copy link
Contributor

Close & follow up on this epic instead: #3944

@github-project-automation github-project-automation bot moved this from Icebox to Review + QA in Menlo Nov 4, 2024
@imtuyethan imtuyethan moved this from Review + QA to Completed in Menlo Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: accessibility Accessibility and shortcuts P2: nice to have Nice to have feature type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants