Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Device classes and Unit of measurement for Power entities generated based on Heating Actuator with energy measurement. #30

Open
gunmalmg opened this issue Apr 25, 2024 · 1 comment

Comments

@gunmalmg
Copy link

gunmalmg commented Apr 25, 2024

Hi
Thank you for providing us with a HA-integration for X-confort Bridge 👏

But there is i bug on Device class and Unit of measurement for Power entities generated based on Heating Actuator with energy measurement.
These Heating Actuator with energy measurement provides 2 separate sensors:

  • Power (W)
  • Energy (kWh)

The integration generates a correct entity for Energy (kWh) , but the Power entity has wrong Device class and Unit of measurement. (it has the same as the Energy entity)
The Power entity should have Device class: Power , and Unit of measurement: W

This is a fundamental error - and I hope it is a easy error to fix. 🙏

Regards
Gunnar

8A0E7016-1213-4E19-823C-6F081E820E48_4_5005_c

@alex-w2
Copy link

alex-w2 commented Sep 29, 2024

@gunmalmg I made some changes in #34 which also includes the change you suggest. I don't have any devices actually reporting power/energy so can't test it though. Great if you're able to test, else we'll need to wait for the pull request to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants