Partials indentation #705
Merged
Partials indentation #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for the quick response! I'm currently on holiday, will have
a look when I'm back.
…On Tue, 9 Jul 2019 at 08:46, Yotam Madem ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#705
Commit Summary
- Indent Partials
- merge with master
- add mustache partials spec and fix one broken test
File Changes
- *M* mustache.js
<https://github.com/janl/mustache.js/pull/705/files#diff-0> (44)
- *M* test/mustache-spec-test.js
<https://github.com/janl/mustache.js/pull/705/files#diff-1> (3)
- *M* test/parse-test.js
<https://github.com/janl/mustache.js/pull/705/files#diff-2> (9)
- *A* test/partial-test.js
<https://github.com/janl/mustache.js/pull/705/files#diff-3> (112)
Patch Links:
- https://github.com/janl/mustache.js/pull/705.patch
- https://github.com/janl/mustache.js/pull/705.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#705?email_source=notifications&email_token=AAJMWE6FVWODGPDSHL2RCWDP6QX4XA5CNFSM4H7CESR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6AP36A>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJMWE6MQ2DQGXVHQV4423TP6QX4XANCNFSM4H7CESRQ>
.
|
LautaroLobo12
approved these changes
Aug 5, 2019
|
Soooo I'm finally back from a long vacation + some general time off the interwebz, sorry for keeping you waiting so long, thanks for your patience. |
phillipj
reviewed
Aug 19, 2019
As referenced in this issue: #562 Partials aren't indented as per the spec: https://github.com/mustache/spec/blob/master/specs/partials.yml#L13-L15 This adds indentation tracking for partials and applies them to the first instance of a partial on a line (to not indent inline partials which would violate a different part of the spec).
|
Great work and thank you so much for your patience! 👍 FYI with the main intention of cleaning up the commits before landing, I got rid of the merge-with-master commit + latest |
|
Thanks Phillipe for reviewing and merging the solution. Now I will finally be able to use the official mustsche module at my work place. (Until now I used a forked version) |
|
v3.0.2 just got published to npm, so enjoy 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for: #562