-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Remove build output from repository #765
Comments
A braindump as a future reference before starting on the work to make this happen: The These days With the above in mind, ensuring we keep backwards compatibility & In the git repository:
In the npm package:
|
I've been playing around with this in the Most challenges faced so far has been fixable, but I just realised removing |
@zekth you were of big help about a year ago when the source code transition to being written in ESM in Are you still into using deno these days? I'm really curious if you know of any protips that would allow us to remove If there's no way for us to make that transition completely transparent for deno users, maybe at least introduce a deprecation warning only trigger when executed via deno a while before actually deleting |
Lately i'm not on Deno but still following the development. There is several package registries and @kitsonk worked on making pika.dev work properly with Deno. It now has moved to https://www.skypack.dev/ and seems like the more reliable way to move forward for mustache. |
Thanks for the quick reply! Interesting. I for some reason had the impression deno users had a strong github.com preference. Valuable to know that's not correct and skypack.dev, unpkg.com etc is on the table. That obviously makes a big difference as we can recommend end-users using the build output wrapped into the npm package, consumed from whatever service of their preference, rather than the source code on github.com directly. Still would be a hard one-time breaking change for current deno users tho. |
For stuff built on Deno, people throw it up on GitHub and register the package at Personal opinion is that if it isn't built for Deno, focusing on maximising compatibility with |
Much appreciated @kitsonk! |
Intro
We want to remove the build output (
mustache.js
andmustache.min.js
) from the git repository.This has been kept around for historical reasons. Being allowed to use github.com directly in a
<script>
element is really convenient and sufficient for many. Until recent years, there has not been viable approaches for using<script>
elements with released versions of mustache.js available on npmjs.com.This request-for-comments issue is created to give consumers a heads-up and open up for them to raise their concerns.
Currently the plan is to remove the build output from the git repository in the start of December 2020.
Why?
There are numerous reasons having the build output in the git repository causes pain, most importantly:
mustache.mjs
) and the build outputWho will be affected?
Those downloading
mustache.js
directly from github.com in their website:What's the alternative?
Download mustache.js from unpkg.com instead:
(ideally with a version specifier instead of
latest
, more on that on unpkg.com)Will this affect the npm package?
No.
The text was updated successfully, but these errors were encountered: