Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an add-on ID #27

Open
3hhh opened this issue Feb 1, 2020 · 3 comments
Open

Add an add-on ID #27

3hhh opened this issue Feb 1, 2020 · 3 comments

Comments

@3hhh
Copy link

3hhh commented Feb 1, 2020

It would make sense to set an add-on ID in the manifest.json as it's still used in some areas in firefox (e.g. for addon sideloading).

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings

"browser_specific_settings": {
  "gecko": {
    "id": "addon@example.com"
  }
}
@jannispinter
Copy link
Owner

I've already tried that, but AMO won't let me publish an update with a different extension ID than the one it automatically generated. Any idea how to fix this?

@3hhh
Copy link
Author

3hhh commented Feb 1, 2020

I've already tried that, but AMO won't let me publish an update with a different extension ID than the one it automatically generated. Any idea how to fix this?

That's strange. I just checked about:support and the IndicateTLS addon ID is {252ee273-8c8d-4609-b54d-62ae345be0a1} which looks like it was generated. If it's the same for everyone, then I'd probably just pick it for the manifest.json entry.

Their doc says (https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/#When_do_you_need_an_add-on_ID):

Publishing
Once you have finished developing the extension, you can package it and submit it to AMO for review and signing. If the packaged extension you upload does not contain an ID, AMO will generate one for you. It’s only at this point that the add-on will be assigned a permanent ID, which will be embedded in the signed packaged extension.

Note that once an extension has been given a permanent ID, you can’t then update it to use the Add-on SDK or legacy XUL/XPCOM techniques. If you do switch to one of these platforms, you must submit it as a distinct new add-on, with a new ID.

Otherwise if even the AMO generated ID cannot be added, I guess this can be closed as not resolvable.

@jannispinter
Copy link
Owner

Thank you for the hint! I will try adding {252ee273-8c8d-4609-b54d-62ae345be0a1} for the next release, as it is the same ID for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants