Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options conversion #65

Closed
pingu-codes opened this issue Mar 30, 2022 · 1 comment
Closed

Fix options conversion #65

pingu-codes opened this issue Mar 30, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pingu-codes
Copy link
Contributor

pingu-codes commented Mar 30, 2022

Options is currently mapped to _options to convert "raw" options to objects with label/value for objects it uses this check
if (!op.value) op.value = op.label;
to check for ops without values however this is incorrectly flagged on a value of 0 I'd suggest the check is changed to if(op.value == undefined)

@janosh janosh added the bug Something isn't working label Mar 30, 2022
@janosh janosh self-assigned this Mar 30, 2022
@janosh janosh closed this as completed in 4c29b9c Mar 30, 2022
@janosh
Copy link
Owner

janosh commented Mar 30, 2022

@GodPingu Thanks for reporting! Will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants