Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed full lodash library import #786

Closed
wants to merge 2 commits into from
Closed

Removed full lodash library import #786

wants to merge 2 commits into from

Conversation

aduryagin
Copy link

No description provided.

@aduryagin aduryagin changed the title asd Removed full lodash library import Sep 18, 2017
@mastilver
Copy link
Collaborator

Thank you for you PR
Although I don't think I'm going to merge it

But I'm sure we can get rid of lodash all together on version 3 (as we will only be supporting node 4 or 6)

@aduryagin
Copy link
Author

Well, we will wait for the 3rd version)

@lukeed
Copy link

lukeed commented Dec 27, 2017

This could easily be a patch release! So tired of seeing all these messages in my build:

[BABEL] Note: The code generator has deoptimised the styling of "~/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".

jantimon added a commit that referenced this pull request Mar 25, 2018
Stop using webpack module rules inside the loader to get rid of the babel 500kb warning

fix #786
jantimon added a commit that referenced this pull request Mar 25, 2018
Stop using webpack module rules inside the loader to get rid of the babel 500kb warning

fix #786
@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants