Feature Request: Enable setting the sts URL via env or flag

[sudermanjr]

Currently this assumes that the sts url is the amazon commercial URL. It would be nice to specify an alternative for use with things like govcloud

[jantman]

@sudermanjr Is there any sort of accepted standard for how to set this, i.e. via an environment variable?

I'd accept a PR for this, but I assume that it's also simple enough to just make a quick fix. Do you happen to have a link to some docs on the various STS URLs, or examples?

[sudermanjr]

I don't think there's a standard AWS environment variable you would use or set here, but I'm not certain. It's probably up to this tool to decide how to do it in this case.

Here's the docs on govcloud endpoints https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/using-govcloud-endpoints.html and the ddocs on regional endpoints - https://docs.aws.amazon.com/general/latest/gr/rande.html

STS is a bit of a weird one since using a regional endpoint really shouldn't be necessary.

I ended up actually re-implementing this functionality in Go because it integrates better with our internal tooling - https://github.com/FairwindsOps/vaultutil (if you're curious how we did it)

[jantman]

@sudermanjr I've added a fix for this in #21 which is currently in https://github.com/jantman/vault-aws-creds/tree/signin-host

If you have a chance to test that, it would be wonderful. If not, I'll just release it sometime next week. I've also added a link to your vaultutil project in the README.

[sudermanjr]

That fix looks good to me. Not sure I'll get a chance to test it, but if I find any issues I will let you know.

Thanks!