You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if (" ".join(lowered_split[-2:])).lower() inpl_sb_irregular_compound:
Unless I am mistaken the code should rename the variable to lowered_dash_split, for the first lines, and create a second variable (could be the existing name) that is whitespace split, to be used in the second set of lines
In #153, I've done some work to refactor the handling of prepositional phrases (dash- and space-separated). This new code avoids conflating the purposes of these two blocks, which may make it easier to resolve the issue.
Can you provide an example of what unexpected result you get based on the current implementation?
In function _plnoun(), on this line you split on dashes - the variable name isn't well chosen
inflect/inflect.py
Line 2672 in 00c4479
Later on, you start using this variable again, but it seems like the code is intended for whitespace split lowerd words, not dash split:
inflect/inflect.py
Line 2717 in 00c4479
Unless I am mistaken the code should rename the variable to lowered_dash_split, for the first lines, and create a second variable (could be the existing name) that is whitespace split, to be used in the second set of lines
#127 contains my suggested fix
The text was updated successfully, but these errors were encountered: