Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network detection logic should supplement 'network' marker #5

Closed
jaraco opened this issue Dec 31, 2022 · 0 comments
Closed

Network detection logic should supplement 'network' marker #5

jaraco opened this issue Dec 31, 2022 · 0 comments

Comments

@jaraco
Copy link
Owner

jaraco commented Dec 31, 2022

In jaraco/pip-run#65 (comment), I learned that there's a convention of marking network-reliant tests with the network marker. Instead of the needs_internet fixture, this project should align with that marker convention and inject the fixture on tests marked with network.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco