Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of empty username support in keyring 25.3.0 breaks several tests #54

Closed
musicinmybrain opened this issue Aug 4, 2024 · 2 comments · Fixed by #55
Closed

Removal of empty username support in keyring 25.3.0 breaks several tests #54

musicinmybrain opened this issue Aug 4, 2024 · 2 comments · Fixed by #55

Comments

@musicinmybrain
Copy link

$ gh repo clone jaraco/keyrings.alt
$ cd keyrings.alt
$ tox
[…]
=========================================================================================== short test summary info ============================================================================================
FAILED tests/mocks.py::ruff
FAILED tests/test_crypto.py::TestCryptedFileKeyring::test_empty_username - ValueError: Username cannot be blank.
FAILED tests/test_file.py::TestEncryptedFileKeyring::test_empty_username[Crypto] - ValueError: Username cannot be blank.
FAILED tests/test_file.py::TestEncryptedFileKeyring::test_empty_username[Cryptodome] - ValueError: Username cannot be blank.
FAILED tests/test_file.py::TestUncryptedFileKeyring::test_empty_username - ValueError: Username cannot be blank.
================================================================================== 5 failed, 154 passed, 81 skipped in 9.05s ===================================================================================
@musicinmybrain
Copy link
Author

While this appears to be triggered by jaraco/keyring#687, the ValueError comes from keyrings.alt:

raise ValueError("Username cannot be blank.")

@mitya57
Copy link
Contributor

mitya57 commented Aug 10, 2024

I submitted PR #55 which is one of possible solutions for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants