Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VisibilityNotify X11 events instead of checking for _NET_WM_STATE_FULLSCREEN #68

Closed
KomaGR opened this issue Oct 7, 2018 · 3 comments
Assignees

Comments

@KomaGR
Copy link

KomaGR commented Oct 7, 2018

As stated, the visualiser ceases to update its animation the moment full-screen window is focused. My most prominent examples are Netflix and YouTube on full-screen.

When the full-screen video is focused the visualiser locks in place. When it is unfocused it picks up the stream anew.

Is this behaviour intended?

@mmhobi7
Copy link
Contributor

mmhobi7 commented Oct 7, 2018

yes, is it that your visualizer is ontop of the full screen window or that it's on another display? regardless yeah and I'll handle this one if u want wacossusca

  • add a check to see if window is fullscreen if glava is unmanaged,
  • do something about full screen on another display
    or just add a setting in rc

@jarcode-foss jarcode-foss self-assigned this Oct 8, 2018
@jarcode-foss
Copy link
Owner

As it says in rc.glsl:

/* Enable/disable fullscreen checks. This looks at the currently
   focused window and halts GLava's rendering if it is
   fullscreen. This prevents rendering from interfering with
   other graphically intensive tasks. */
#request setfullscreencheck true```

It's intended and configurable. You can also use #request setxwintype "!+" in some WMs if you want to display GLava over fullscreen windows (see #65), although I'm guessing you just had it running on another monitor.

It may be more elegant to use VisibilityNotify events (if the state member is set to VisibilityFullyObscured), that way users don't need to muck with this option.

@jarcode-foss jarcode-foss changed the title Visualiser not updating when full-screen window is focused Use VisibilityNotify X11 events instead of checking for _NET_WM_STATE_FULLSCREEN Oct 8, 2018
@jarcode-foss
Copy link
Owner

@KomaGR GLava (master) is now smarter about detecting when it is visible; minimized and obscured windows will suspend rendering, and the fullscreen check is disabled by default now (as it's mostly made obsolete by this change, although some users may want it enabled on multi-monitor setups).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants