Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print button no longer works with 1.5.0 release #133

Open
billerickson opened this issue Feb 19, 2024 · 0 comments
Open

Print button no longer works with 1.5.0 release #133

billerickson opened this issue Feb 19, 2024 · 0 comments

Comments

@billerickson
Copy link
Collaborator

In #130 we replaced esc_attr() with esc_url(), which broke the print button link because it used JavaScript (see code).

We either need to revert this change or update the print button to not use the href parameter for triggering the print window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billerickson