-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth info in basic callback #14
Comments
Also noticed the same issue. Just need to include info as an argument to verified (basic.js line 88) and the self.success call (basic.js line 91) |
+1 |
+1. I think it's a very interesting change because allow send customized data back to client. It is also very simple one. Thank you |
+1 |
Pull request created... |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment you are not taking info in basic auth callback. So extra information about authenticated client cannot be passed to req.authInfo object.
I changed code as follows.
this._verify(userid, password, function(err, user, info) {
if (err) { return self.error(err); }
if (!user) { return self.fail(self._challenge()); }
self.success(user, info);
});
I am sure others would also benefit if you change code as above.
The text was updated successfully, but these errors were encountered: