Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth info in basic callback #14

Open
rgjamkhedkar opened this issue May 27, 2013 · 6 comments
Open

Add auth info in basic callback #14

rgjamkhedkar opened this issue May 27, 2013 · 6 comments

Comments

@rgjamkhedkar
Copy link

At the moment you are not taking info in basic auth callback. So extra information about authenticated client cannot be passed to req.authInfo object.
I changed code as follows.
this._verify(userid, password, function(err, user, info) {
if (err) { return self.error(err); }
if (!user) { return self.fail(self._challenge()); }
self.success(user, info);
});

I am sure others would also benefit if you change code as above.

@mcgrews3
Copy link

Also noticed the same issue. Just need to include info as an argument to verified (basic.js line 88) and the self.success call (basic.js line 91)

@JasonCust
Copy link

+1

@datuary-jmartinez
Copy link

+1. I think it's a very interesting change because allow send customized data back to client. It is also very simple one. Thank you

@markwainwright
Copy link

+1

@mcgrews3
Copy link

mcgrews3 commented Sep 6, 2015

Pull request created...

#48

@tgyhlsb
Copy link

tgyhlsb commented Mar 31, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants