Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New site breaks non-JS browsers #353

Closed
joepie91 opened this issue May 19, 2015 · 2 comments
Closed

New site breaks non-JS browsers #353

joepie91 opened this issue May 19, 2015 · 2 comments

Comments

@joepie91
Copy link

Upon finding that the site for Passport had changed significantly, and that it used a lot of fancy JS "enhancements", I decided to have a look at how well it functioned without JS. As it turns out, it doesn't, at all.

The "view strategies" button is completely broken. "Section jumping" in the documentation is completely broken. Neither of these are functionality that absolutely requires JS. Whatever happened to the practice of progressive enhancement?

Documentation should really be available to anybody with a web browser (and, ideally, even to people without a web browser). There are many people who either cannot enable JS in their browser, do not want to enable JS in their browser (eg. for security reasons), or who recursively download a site because their internet connection is unreliable/limited.

The current site breaks all of these usecases, and that should really be fixed.

@jaredhanson
Copy link
Owner

Issues with the website do not affect the Node.js module itself, and should be filed on the relevant GitHub project: https://github.com/passport/www.passportjs.org

The redesign has just launched, so I'm sure there are things that may need to be fixed or revised. When filing issues for things that are not working correctly, please indicate which browser and device you are using as well as what behavior you expected.

Pull requests that improve progressive enhancement and accessibility are greatly welcome!

@joepie91
Copy link
Author

Aha. I was looking for the website repo, but couldn't find it - it doesn't seem to be linked from the (new) site anywhere. I'll re-file there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants