Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formik 1.0.0-beta.0 comes with broken import statements #625

Closed
karol-majewski opened this issue May 12, 2018 · 1 comment
Closed

Formik 1.0.0-beta.0 comes with broken import statements #625

karol-majewski opened this issue May 12, 2018 · 1 comment

Comments

@karol-majewski
Copy link

Describe the bug

Updating to '1.0.0-beta.0' broke my build due to the use of synthetic default imports. If you take a look at the history, you can see that what previously was import * as React from 'react' now becomes import React from React.

To Reproduce
Run tsc in your repository while having "allowSyntheticDefaultImports": false in your tsconfig.json.

Expected behavior
If 1.0.0-alpha.6 compiled without errors, 1.0.0-beta.0 should compile without errors as well, since the new version promises to deliver no breaking changes.

Suggested solution(s)
Turn the allowSyntheticDefaultImports flag to false in tsconfig.base.json file, and adjust the import statements accordingly. This way it will work for everyone.

Additional context

  • Formik Version: 1.0.0-beta.0
  • React Version:16.3.2
  • TypeScript Version: 2.8.3
  • OS: macOS
  • Node Version: 10.0.0.
  • Package Manager and Version: npm@6.0.0
@jaredpalmer
Copy link
Owner

jaredpalmer commented May 12, 2018

Will fix. thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants