Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Typescript type definitions incorrect #768

Closed
danielwong2268 opened this issue Jul 16, 2018 · 4 comments
Closed

Field Typescript type definitions incorrect #768

danielwong2268 opened this issue Jul 16, 2018 · 4 comments
Labels

Comments

@danielwong2268
Copy link

Current Behavior

Field props has any type.

export declare const Field: React.ComponentClass<any> & {
    WrappedComponent: React.ComponentClass<any>;
};

Expected behavior

Field props should have FieldAttributes type.


  • Formik Version: 1.0.1
  • React Version: 16.4.1
  • TypeScript Version: 2.9.2
  • Browser and Version: Chrome 67
  • OS: OSX
  • Node Version: v8.7
  • Package Manager and Version: yarn 1.6
@jaredpalmer
Copy link
Owner

Yes. This is until TS JSX generics become more widely used

@tgriesser
Copy link
Contributor

@jaredpalmer I don't believe that TS JSX generics need to be used to get these type definitions correct in the output d.ts though. Using a wrapper component rather than connect as I started doing in #735 should do the trick.

@stale
Copy link

stale bot commented Sep 16, 2018

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

@stale stale bot added the stale label Sep 16, 2018
@stale
Copy link

stale bot commented Sep 23, 2018

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

@stale stale bot closed this as completed Sep 23, 2018
This was referenced Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants