Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lcov code coverage output is incorrect for TypeScript #439

Closed
timothymclane opened this issue Dec 21, 2017 · 3 comments
Closed

lcov code coverage output is incorrect for TypeScript #439

timothymclane opened this issue Dec 21, 2017 · 3 comments

Comments

@timothymclane
Copy link
Contributor

Since Jest 20, ts-jest no longer does code coverage mapping for TypeScript projects. Instead, it's recommended to use Jest's mapCoverage option.

Given Razzle does not currently support passing mapCoverage to Jest, code coverage output can be incorrect for TypeScript projects.

Example:

unmapped

The simplest solution I can see is to just add mapCoverage to supportedKeys in createJestConfig, unless that would cause some other issue, but it appears to work just fine.

After editing createJestConfig to allow mapCoverage: true:

mapped
@jaredpalmer
Copy link
Owner

That’s fine

@timothymclane timothymclane mentioned this issue Dec 30, 2017
Merged
@LavaToaster
Copy link

It's probably worth closing this issue. :)

@timothymclane
Copy link
Contributor Author

Quite right!

@snyk-bot snyk-bot mentioned this issue Dec 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LavaToaster @jaredpalmer @timothymclane