Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error overlay works even without defining the crossorigin attribute #445

Closed
kireerik opened this issue Jan 5, 2018 · 3 comments
Closed

Comments

@kireerik
Copy link
Contributor

kireerik commented Jan 5, 2018

This can be reproduced by removing the crossorigin attribute here in the basic example and writing some syntax errors for example:

: `<script src="${assets.client.js}" defer crossorigin></script>`}

@jaredpalmer
Copy link
Owner

hmmm... it didn't for a while. have to examine that. it was added because react needed to know it was being served during dev from another port (and so it should consider that a CDN).

@kireerik
Copy link
Contributor Author

I see. Does it works for you as well with the current version? Do you think that the crossorigin attribute can be removed?

@kireerik
Copy link
Contributor Author

kireerik commented Jun 1, 2018

As I can see in the README the crossorigin attribute is only needed if a CDN is used for example.
Note: The basic and other examples are using it.

I think we can probably close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants