Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Question #670

Closed
rhodee opened this issue Jun 19, 2018 · 6 comments
Closed

Plugin Question #670

rhodee opened this issue Jun 19, 2018 · 6 comments
Assignees

Comments

@rhodee
Copy link
Collaborator

rhodee commented Jun 19, 2018

Hey so I built a plugin and had some questions (Plugin here: https://github.com/rhodee/razzle-plugin-pwa). It should work given this line: https://github.com/jaredpalmer/razzle/blob/master/packages/razzle/config/runPlugin.js#L9.

I am happy to discuss design, but generally I followed the razzle-plugin-typescript model to get to this point. If it makes sense to add this to the the repo as package, I'd be happy to make a PR, it didn't feel like a core addition, but I can be persuaded otherwise.

Cheers - D

@rhodee
Copy link
Collaborator Author

rhodee commented Jun 19, 2018

I was hoping to keep the package bumps in line with Razzle itself. Not sure that is a requirement, but it could be a nice feature for users. Thoughts?

@jaredpalmer
Copy link
Owner

This is awesome. Would love to add as a package!

@rhodee
Copy link
Collaborator Author

rhodee commented Jun 19, 2018

Awesome. I did this one too: https://github.com/rhodee/razzle-plugin-postcss

@rhodee
Copy link
Collaborator Author

rhodee commented Jun 19, 2018

Should create a test project in examples and then play around a bit at work. I wrote both in TS, which leads me to wonder how best to integrate. Leave me your thoughts, in the meantime.

@stale
Copy link

stale bot commented Aug 18, 2018

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

@stale stale bot added the stale label Aug 18, 2018
@stale
Copy link

stale bot commented Aug 25, 2018

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants