-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Allow specifying external module names for UMD (rollup output.globals) #132
Comments
this one comes from rollup which comes from node. tbh i'd like to suppress this output altogether if we're not even building UMD. |
Well, as I said, why not to get inspired by microbundle? I like the way they tackled it in there with CLI option. https://github.com/developit/microbundle#all-cli-options |
I'm playing around with trying to use TSDX with Redux Starter Kit, and the guessing behavior is pretty unhelpful. It's producing this output: (global = global || self, factory(global.ReduxStarterKit = {}, global.redux, global.createNextState, global.selectorator, global.reduxDevtoolsExtension, global.thunk)); Pretty sure none of those match the actual global names from the UMD builds of those respective libs. (Not that I expect a build tool to actually parse or come up with those correctly.) |
Sounds good. —external makes sense |
So I think configuring Rollup's |
Current Behavior
Expected behavior
It does guess the names correct in this case but a nicer output would be great. You may notice that guessed name for the last
react-dom
is not even visible. It could lead to unexpected results if it would guess in the wrong way.Suggested solution(s)
I wonder why it's not possible to specify externals in a similar fashion as microbundle does. Since it would be optional, it doesn't make the whole experience of zero configuration any worse.
Additional context
Used in building the https://github.com/JustFly1984/react-google-maps-api
Your environment
The text was updated successfully, but these errors were encountered: