No .d.ts created after update to 0.10.0

[dattebayorob]

Current Behavior

in 0.10.0

//index.ts
import { PrivateRoute, PublicRoute } from "./components";

export {
  PrivateRoute,
  PublicRoute
}

will generate

//index.d.ts
export { PrivateRoute, PublicRoute };

and directories of components with .d.ts aren't created

Expected behavior

In 0.9.3 the .d.ts are created:

//index.d.ts
import { PrivateRoute, PublicRoute } from "./components";
export { PrivateRoute, PublicRoute };

Suggested solution(s)

Additional context

Your environment

Software	Version(s)
TSDX	>=0.10.0
TypeScript	^3.6.4
Browser
npm/Yarn	v1.17.3
Operating System	Arch

[tabuckner]

I'm running into a similar issue and just assumed it was a quirk with the project.

@dattebayorob Was this working for you on a previous version?

[tabuckner]

@dattebayorob I've updated your comment above.

I can also confirm that this seems to be introduced in the first 0.10.0 release

[tabuckner]

Maybe this?

[tabuckner]

potential related bug?
wessberg/rollup-plugin-ts#31

[tabuckner]

it looks like we swapped rollup-plugin-typescript2 for @wessberg/rollup-plugin-ts

I've got a few other projects that are using rollup and rollup-plugin-typescript2, those are working in the way we'd expect.

There was almost definitely a reason that we switched to the new package though, right?

[tabuckner]

Maybe the config is wrong here?
https://github.com/jaredpalmer/tsdx/blob/master/src/createRollupConfig.ts#L130

[jaredpalmer]

@wessberg?

[jaredpalmer]

It seems like this plugin is not yet stable. I think we should go back to Rollup-typescript2

[sadsa]

@jaredpalmer - was this not part of a fix for - Support for async/await in rollup plugins?
e.g. vladshcherbin/rollup-plugin-copy#16

[wessberg]

@tabuckner, The reason why you're seeing a different file structure now in terms of where declaration files are emitted to is that rollup-plugin-ts bundles your declaration files and follows Rollups file structure. Meaning, a declaration file is generated per chunk. Previously, you were seeing declarations being generated (not bundled) that simply followed the source structure, even though the folders only contained declarations. So that at least explains the difference in the file structure.

If you instead do:

export {PrivateRoute, PublicRoute} from "./components";

Does that produce correct declarations inside index.d.ts?

I haven't verified it yet, but I think what's happening is that the tree-shaking step of the declaration bundling phase of rollup-plugin-ts determines that the two import bindings are unused given that they are referenced only by the ExportSpecifiers in the ExportDeclaration that reexports them. I'll look into it.

There was almost definitely a reason that we switched to the new package though, right?

I really don't know why, but I think the combination of declaration bundling, ease of combining with Babel and support for plugins with async functions (to work around an object-hash limitation) were the primary reasons.

[dattebayorob]

If you instead do:

export {PrivateRoute, PublicRoute} from "./components";

Does that produce correct declarations inside index.d.ts?

No, the .d.ts creates a

export { PrivateRoute, PublicRoute };

[tabuckner]

@wessberg Here's an repro repo that shows the issues I ran into with v0.10.0 of tsdx and on.

It's not the exact scenario you outline and @dattebayorob confirmed, but it does seem to be related.

https://github.com/tabuckner/tsdx-0.10.x-type-defs-repro

[dattebayorob]

I will try to setup with the @wessberg/rollup-plugin-ts now, I need a async plugin now, and the typescript2 hack to get it to work doesn't seem like a good idea

[dattebayorob]

ombination of declaration bund

On src/index.ts

export * from './components'; export * from './annotations'; export * from './templates';

The generated dist/index.d.ts
export {};

[jaredpalmer]

@dattebayorob @tabuckner what version of node are you all using?

[tabuckner]

v10.15.3

I'll try with some other versions as well.

[tabuckner]

declare const sum: (a: number, b: number) => number;
declare const log: (str: string) => void;
export * from "../src/util/cool-thing/models/cool-thing-input";
export * from "../src/util/cool-thing/models/cool-thing-output";
export { sum, log };

[tabuckner]

declare const sum: (a: number, b: number) => number;
declare const log: (str: string) => void;
export * from "../src/util/cool-thing/models/cool-thing-input";
export * from "../src/util/cool-thing/models/cool-thing-output";
export { sum, log };

[dattebayorob]

I'm on 11.15.0

[jaredpalmer]

Is this the default or did you use it with an async Rollup plugin?

[dattebayorob]

With default plugins

[wessberg]

@wessberg Here's an repro repo that shows the issues I ran into with v0.10.0 of tsdx and on.

It's not the exact scenario you outline and @dattebayorob confirmed, but it does seem to be related.

https://github.com/tabuckner/tsdx-0.10.x-type-defs-repro

Thanks for the repro. I'll take a look at it and will report back here.

[wessberg]

Alright, I've fixed the issues and released v1.1.73. There were two of them:

• Directory imports were being used coupled with Node module resolution. There was an issue related to this, which has been resolved.
• Module Specifiers following the form ./cool-thing-input.interface were being used, and .interface was being mistakenly interpreted as the file extension when reading from disk

Here's the declaration output based on your repro in the new version:

interface ICoolThingInput {
    message: string;
    id?: number;
}
interface ICoolThingOutput {
    name: string;
    id: number;
    message: {
        text: string;
        code: number;
    };
}
declare const sum: (a: number, b: number) => number;
declare const log: (str: string) => void;
declare const doCoolThings: (input: ICoolThingInput) => ICoolThingOutput;
export { sum, log, doCoolThings, ICoolThingInput, ICoolThingOutput };

I'm unaware if this also fixes the issue that the original issue author had since I have no repro for it, but I hope so.

[dattebayorob]

I did some tests with the new rollup-plugin-ts:
export components manually:

import { Row, Col } from './components';

Will generate declarations correctly:

import React from "react";
declare const Col: React.FC;
declare const Row: React.FC;
export { Row, Col };

But if a export * :

export * from './components'

lends to

export {};

Here a repo sample

[wessberg]

@dattebayorob, The issue you reported has been fixed in the latest version of rollup-plugin-ts.