Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated typings are broken #285

Closed
z0al opened this issue Oct 26, 2019 · 6 comments
Closed

Generated typings are broken #285

z0al opened this issue Oct 26, 2019 · 6 comments
Labels
kind: bug Something isn't working scope: upstream Issue in upstream dependency topic: v0.10.x Issues related to broken builds in v0.10.x / @wessberg/rollup-plugin-ts

Comments

@z0al
Copy link

z0al commented Oct 26, 2019

Current Behavior

Generated typings are broken (literally) starting from v0.10.0. Here are some snippets:

    interface Query extends Object {
        id: ID;
        type?: ch;
        ';;
        exp;
    }
    interface Query extends Object {
        id: ID;
        type?: xport;
        fu;
    }

And YES, it duplicated almost every type declaration (see the full file here)

Expected behavior

Typings don't have syntax errors.

Suggested solution(s)

I think it's a bug in @wessberg/rollup-plugin-ts. I tried that lib before in a different project but quickly removed it due to the same issue.

Your environment

Software Version(s)
TSDX >= v0.10.0
TypeScript 3.6.4
Browser N/A
npm/Yarn 6.11.3
Node 12.8.1
Operating System Debian Linux
@z0al
Copy link
Author

z0al commented Oct 27, 2019

I tried updating @wessberg/rollup-plugin-ts to the latest version (v1.1.73 instead of v1.1.70) but the output is still the same. I will try to create a minimal reproducible repo later.

@samdenty
Copy link
Contributor

samdenty commented Oct 29, 2019

For me, it's not exporting all the types. The dts declaration merging is broken

0.9.3 okay:

import { Type } from 'library'

1.10.0: error, type not exported

@z0al
Copy link
Author

z0al commented Oct 29, 2019

Fixed in #287

@z0al z0al closed this as completed Oct 29, 2019
@wessberg
Copy link

Sorry about that, do you have a minimal repro I can take a look at? It would be great if you submitted this as an issue over at rollup-plugin-ts

@z0al
Copy link
Author

z0al commented Oct 29, 2019

No worries. I will do if I could reproduce it in a small repo, thanks.

@wessberg
Copy link

wessberg commented Nov 9, 2019

@z0al, The issue with malformed typings you reported has been fixed in the latest version of rollup-plugin-ts.

@agilgur5 agilgur5 added kind: bug Something isn't working scope: upstream Issue in upstream dependency topic: v0.10.x Issues related to broken builds in v0.10.x / @wessberg/rollup-plugin-ts labels Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working scope: upstream Issue in upstream dependency topic: v0.10.x Issues related to broken builds in v0.10.x / @wessberg/rollup-plugin-ts
Projects
None yet
Development

No branches or pull requests

4 participants