-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-only/Emit-less TS files aren't being checked #725
Comments
Sounds like this might be similar to #527 which never provided a repro. |
Yeah, rollup prunes unused sources, so rtp2 plugin might never see something not imported by entry file. |
I did some research on this in the past few weeks/months and found a reference to the original issue in We don't use @ezolenko thanks for responding here. Per that issue, I thought this was fixed by ezolenko/rollup-plugin-typescript2@448913d with the current code here? Does that only handle entry files? Can we workaround that? It seems like |
@ezolenko following up about the above |
Noting here that this type-only issue was reproduced upstream in ezolenko/rollup-plugin-typescript2#298.
This was actually the root cause and all of my references were related -- type-only issues were the longest lasting and most common issues in rpt2. |
Current Behavior
After creating a simple
react-with-storybook
tsdx project (usingcreate
), add the following files:src/interfaces/test.ts:
src/interfaces/index.ts:
src/index.tsx:
Using this setup, running
npm run start
"successfully" builds the package, although it should error out due to the above error.In contrast, when I run
tsc --noEmit
, the error is successfully recognized.Expected behavior
When running
npm run start
, I expect it to catch the error.Your environment
Find the minimal example from above here:
lib2.zip
The text was updated successfully, but these errors were encountered: