Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel isn't running -- need to add TS, TSX extensions to rollup-plugin-babel config #95

Closed
jakegavin opened this issue May 9, 2019 · 0 comments · Fixed by #96
Closed
Labels
kind: bug Something isn't working

Comments

@jakegavin
Copy link
Contributor

jakegavin commented May 9, 2019

Current Behavior

The babel plugin doesn't run on transpiled ts code so features like lodash import renaming, pure call annotation, and the dev expression plugin don't work.

Example bundle: https://github.com/jakegavin/tsdx-babel-issue/blob/master/dist/tsdx-babel-issue.cjs.development.js#L3

Babel doesn't run on the output of the rollup-plugin-typescript2 unless "ts" is specified as an extension in the in the babel config. This is discussed here: ezolenko/rollup-plugin-typescript2#108

Expected behavior

Babel should run on output of the typescript plugin.

Example bundle: https://github.com/jakegavin/tsdx-babel-issue/blob/build-with-fixed-tsdx/dist/tsdx-babel-issue.cjs.development.js#L3

Suggested solution(s)

Add "ts" and "tsx" extensions to the babel config. PR: #96

Additional context

Your environment

Software Version(s)
TSDX 0.5.8
TypeScript 3.4.5
Browser chrome
npm/Yarn npm
Operating System macos
@agilgur5 agilgur5 added the kind: bug Something isn't working label Mar 10, 2020
@agilgur5 agilgur5 changed the title Babel isn't runing Babel isn't running -- need to add TS, TSX extensions to Babel config Mar 10, 2020
@agilgur5 agilgur5 changed the title Babel isn't running -- need to add TS, TSX extensions to Babel config Babel isn't running -- need to add TS, TSX extensions to rollup-plugin-babel config Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants