Square Libs missing #15

ruclip · 2017-06-09T12:40:53Z

Hi,

great Job with you Lib! This lib help me a lot to generating my open source view automatically. Thank you!

I found one big problem:

Some dependencies (square etc.) in generated JSON and HTML file are missing.

Dependencies:

// Support
    compile "com.android.support:appcompat-v7:${supportVersion}"
    compile "com.android.support:design:${supportVersion}"
    compile "com.android.support:support-v13:${supportVersion}"
    compile "com.android.support:percent:${supportVersion}"
    compile "com.android.support:recyclerview-v7:${supportVersion}"

    //Annotations
    apt "org.androidannotations:androidannotations:${androidannotationsVersion}"
    compile "org.androidannotations:androidannotations-api:${androidannotationsVersion}"

    // Network
    compile "com.squareup.retrofit2:retrofit:${retrofitVersion}"
    compile "com.squareup.retrofit2:converter-gson:${retrofitVersion}"
    compile "com.squareup.okhttp3:logging-interceptor:${okhttpVersion}"
    compile "com.squareup.okhttp3:okhttp:${okhttpVersion}"
    compile "com.squareup.okhttp3:okhttp-urlconnection:${okhttpVersion}"
    compile "com.github.bumptech.glide:glide:3.7.0"
    compile 'com.github.bumptech.glide:okhttp3-integration:1.4.0@aar'

    // View
    compile 'me.relex:circleindicator:1.2.1@aar'
    compile 'eu.davidea:flexible-adapter:5.0.0-b8'
    compile 'cn.aigestudio.wheelpicker:WheelPicker:1.1.2'
    compile 'com.daimajia.swipelayout:library:1.2.0@aar'
    compile 'de.hdodenhof:circleimageview:2.1.0'

    // Fonts
    compile 'uk.co.chrisjenx:calligraphy:2.3.0'

    // DevOps
    compile "net.hockeyapp.android:HockeySDK:${hockeyApp}"

    // Logging
    compile "org.slf4j:slf4j-android:${slf4jVersion}"

    // Chuck Interceptor
    debugCompile "com.readystatesoftware.chuck:library:${chuckVersion}"
    debug_testCompile "com.readystatesoftware.chuck:library:${chuckVersion}"
    alphaCompile "com.readystatesoftware.chuck:library-no-op:${chuckVersion}"
    betaCompile "com.readystatesoftware.chuck:library-no-op:${chuckVersion}"
    showcaseCompile "com.readystatesoftware.chuck:library-no-op:${chuckVersion}"
    qsCompile "com.readystatesoftware.chuck:library-no-op:${chuckVersion}"
    releaseCompile "com.readystatesoftware.chuck:library-no-op:${chuckVersion}"

    // Leak Canary
    debugCompile "com.squareup.leakcanary:leakcanary-android:${leakCanaryVersion}"
    debug_testCompile "com.squareup.leakcanary:leakcanary-android:${leakCanaryVersion}"
    alphaCompile "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryVersion}"
    betaCompile "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryVersion}"
    showcaseCompile "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryVersion}"
    qsCompile "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryVersion}"
    releaseCompile "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryVersion}"
    testCompile "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryVersion}"

Generated JSON:

[
    {
        "project": "Android SwipeLayout Library",
        "developers": "daimajia",
        "url": "https://github.com/daimajia/AndroidSwipeLayout",
        "year": null,
        "license": "MIT",
        "license_url": "http://opensource.org/licenses/MIT"
    },
    {
        "project": "Animated-vector-drawable",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Appcompat-v7",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Calligraphy",
        "developers": "Christopher Jenkins",
        "url": "https://github.com/chrisjenx/Calligraphy",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Chuck no-op",
        "developers": "Jeff Gilfelt",
        "url": "https://github.com/jgilfelt/chuck",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "CircleImageView",
        "developers": "Henning Dodenhof",
        "url": "https://github.com/hdodenhof/CircleImageView",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "CircleIndicator",
        "developers": "relex",
        "url": "https://github.com/ongakuer/CircleIndicator",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Design",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "FlexibleAdapter",
        "developers": "Davide Steduto",
        "url": "https://github.com/davideas/FlexibleAdapter",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Glide",
        "developers": "Sam Judd",
        "url": "https://github.com/bumptech/glide",
        "year": null,
        "license": "Simplified BSD License",
        "license_url": "http://www.opensource.org/licenses/bsd-license"
    },
    {
        "project": "Glide OkHttp 3.x Integration",
        "developers": "Sam Judd",
        "url": "https://github.com/bumptech/glide",
        "year": null,
        "license": "Simplified BSD License",
        "license_url": "http://www.opensource.org/licenses/bsd-license"
    },
    {
        "project": "Hugo Annotations",
        "developers": "Jake Wharton",
        "url": "https://github.com/JakeWharton/hugo/",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "No op LeakCanary for Android",
        "developers": "Square, Inc.",
        "url": "http://github.com/square/leakcanary/",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Percent",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "ReLinker",
        "developers": "KeepSafe",
        "url": "https://github.com/KeepSafe/ReLinker",
        "year": "2015",
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Realm-annotations",
        "developers": null,
        "url": "scm:https://github.com/realm/realm-java",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Recyclerview-v7",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "SLF4J API and Google Android Binding",
        "developers": "Thorsten M\u00f6ller",
        "url": null,
        "year": "2009",
        "license": "The MIT License",
        "license_url": "http://www.opensource.org/licenses/mit-license.php"
    },
    {
        "project": "Simple and fantastic wheel view in realistic effect for android",
        "developers": "Aige",
        "url": "https://github.com/AigeStudio/WheelPicker",
        "year": null,
        "license": "The Apache Software License, Version 2.0",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-annotations",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-compat",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-core-ui",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-core-utils",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-fragment",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-media-compat",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-v13",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-v4",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Support-vector-drawable",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    },
    {
        "project": "Transition",
        "developers": null,
        "url": null,
        "year": null,
        "license": "The Apache Software License",
        "license_url": "http://www.apache.org/licenses/LICENSE-2.0.txt"
    }
]

The text was updated successfully, but these errors were encountered:

jaredsburrows · 2017-07-27T07:56:41Z

Which square libraries specifically? Also, if they are missing, it must be because their license is missing in the POM.xml file.

Tapchicoma · 2017-08-08T12:25:36Z

Maybe the plugin should show warnings for missing licenses on generating the report.

Also It would be nice to provide some way to set license for this "missed" dependencies.

jaredsburrows · 2017-08-08T16:02:16Z

@Tapchicoma I can create an issue for the warnings.

For the missing dependencies, you can edit the .json file that is creates.

Tapchicoma · 2017-08-09T06:25:50Z

Editing the json file is not so nice solution, as it requires manual work afterwards. Then it will be an irritating job to change any dependency.

I prefer fully automatic way - configure once and forget, because it just works. IMHO there should be a way to do it though configuration, either providing some file in extension or some other way. This file should contain mapping to this missing dependencies.

jaredsburrows · 2017-08-15T00:24:13Z

@Tapchicoma Sort of like a "default" or "fallback"?

Tapchicoma · 2017-08-15T09:16:13Z

More like a fallback: when plugin can't figure out dependency info, then it should look for it in this "mapping file".

jaredsburrows · 2017-10-01T18:08:11Z

@Tapchicoma Should the mapping file be included in the plugin?

Tapchicoma · 2017-10-04T17:26:30Z

@jaredsburrows probably no, just to point in README that there is such possibility.

Every project has it own set of dependencies and also it will be easier to maintain the plugin itself.

jaredsburrows · 2017-10-05T18:04:52Z

What would this feature look like? How would it work? If a license is missing, default to Apache 2.0?

Tapchicoma · 2017-10-05T18:16:03Z

In case of missing license plugin should write warning in gradle output.

Optionally: add plugin extension flag that, when enabled, will fail the build on missing license.

jaredsburrows · 2017-10-21T01:29:53Z

I have added logging for developers to show which dependencies are missing POM data.

For example:

$ gradlew licenseDebugReport

> Task :licenseDebugReport
OkHttp Logging Interceptor dependency does not have a license.
Adapter: RxJava 2 dependency does not have a license.
Converter: Moshi dependency does not have a license.
Retrofit dependency does not have a license.
OkHttp dependency does not have a license.
moshi-adapters dependency does not have a license.
Moshi dependency does not have a license.
Okio dependency does not have a license.
Wrote HTML report to /<>/repo/android-gif-example/build/reports/licenses/licenseDebugReport.html.
Wrote JSON report to /<>/repo/android-gif-example/build/reports/licenses/licenseDebugReport.json.


BUILD SUCCESSFUL in 7s
1 actionable task: 1 executed

Source: https://github.com/jaredsburrows/android-gif-example

jaredsburrows · 2017-10-21T01:43:36Z

@ruclip I have reported this issue here: square/retrofit#2529.

If they let me make a PR to add the license information in the POM files, the plugin will pick it up next time.

jaredsburrows · 2017-10-22T03:05:57Z

@ruclip Since the issue was closed, I wrote to support traversing parent POM files here: #20.

jaredsburrows · 2018-01-09T15:17:36Z

Closed by #27.

jaredsburrows mentioned this issue Aug 8, 2017

Show warnings for missing dependencies #17

Closed

jaredsburrows mentioned this issue Dec 28, 2017

Recursively scan parent POMs for license #23

Closed

jaredsburrows mentioned this issue Jan 9, 2018

issue #26 Recursively scan parent POMs for license #27

Merged

jaredsburrows closed this as completed Jan 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Square Libs missing #15

Square Libs missing #15

ruclip commented Jun 9, 2017

jaredsburrows commented Jul 27, 2017

Tapchicoma commented Aug 8, 2017

jaredsburrows commented Aug 8, 2017

Tapchicoma commented Aug 9, 2017

jaredsburrows commented Aug 15, 2017

Tapchicoma commented Aug 15, 2017

jaredsburrows commented Oct 1, 2017

Tapchicoma commented Oct 4, 2017

jaredsburrows commented Oct 5, 2017

Tapchicoma commented Oct 5, 2017

jaredsburrows commented Oct 21, 2017 •

edited

Loading

jaredsburrows commented Oct 21, 2017

jaredsburrows commented Oct 22, 2017

jaredsburrows commented Jan 9, 2018

Square Libs missing #15

Square Libs missing #15

Comments

ruclip commented Jun 9, 2017

jaredsburrows commented Jul 27, 2017

Tapchicoma commented Aug 8, 2017

jaredsburrows commented Aug 8, 2017

Tapchicoma commented Aug 9, 2017

jaredsburrows commented Aug 15, 2017

Tapchicoma commented Aug 15, 2017

jaredsburrows commented Oct 1, 2017

Tapchicoma commented Oct 4, 2017

jaredsburrows commented Oct 5, 2017

Tapchicoma commented Oct 5, 2017

jaredsburrows commented Oct 21, 2017 • edited Loading

jaredsburrows commented Oct 21, 2017

jaredsburrows commented Oct 22, 2017

jaredsburrows commented Jan 9, 2018

jaredsburrows commented Oct 21, 2017 •

edited

Loading