Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating readme to show configuration options #644

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Mar 1, 2024

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
updating readme to show configuration options

@jaredwray jaredwray merged commit 7499974 into master Mar 1, 2024
4 checks passed
@jaredwray jaredwray deleted the updating-readme-to-show-configuration-options branch March 1, 2024 21:28
@adelbke
Copy link

adelbke commented Mar 2, 2024

Thanks for replying.

I checked the code and in the memory cache shouldCloneBeforeSet is set to true by default. As indicated here

@adelbke
Copy link

adelbke commented Mar 2, 2024

Unless I am missing something, please let me know if I did.

@jaredwray
Copy link
Owner Author

@adelbke - LOL I was going too fast. Good catch. Updated here: #645

@adelbke
Copy link

adelbke commented Mar 2, 2024

Yeah...it happens to everyone, even the best 😅

@jaredwray
Copy link
Owner Author

Yeah...it happens to everyone, even the best 😅

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants