Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execve() should polyfill #! on windows #1010

Closed
mwisnicki opened this issue Dec 13, 2023 · 7 comments
Closed

execve() should polyfill #! on windows #1010

mwisnicki opened this issue Dec 13, 2023 · 7 comments
Assignees
Labels
accepted We intend to address this issue.

Comments

@mwisnicki
Copy link

Copied from bellard/quickjs#197:

#!/bin/qjs
console.log("Hello");

It doesn't work when invoked from bash as script:

$ ./test.qjs
./test.qjs: line 2: syntax error near unexpected token `"Hello"'
./test.qjs: line 2: `console.log("Hello");'
$ qjs test.qjs
Hello

The same works with native build.

Running on Windows 11. Problem might me broader than qjs but I haven't checked.

@jart
Copy link
Owner

jart commented Dec 14, 2023

What shell are you using? Cosmopolitan bash?

@mwisnicki
Copy link
Author

Yes

@jart jart changed the title QuickJS shebang not working execve() should polyfill #! on windows Dec 14, 2023
@jart jart added the accepted We intend to address this issue. label Dec 14, 2023
@jart
Copy link
Owner

jart commented Dec 14, 2023

@mrdomino Does adding a feature to execve() sound interesting to you? It's the other side of the coin compared to APE Loader.

@mrdomino
Copy link
Collaborator

Sure!

@mrdomino
Copy link
Collaborator

Sorry for not responding sooner; I received one spam notification from a Github issue I was subscribed to a week ago, and since then ProtonMail has apparently been marking all of my Github notifications as spam.

@mrdomino
Copy link
Collaborator

mrdomino commented Jan 1, 2024

Haven't forgotten about this, just have a bunch of other priorities.

@jart jart self-assigned this Jan 9, 2024
@mrdomino
Copy link
Collaborator

mrdomino commented Apr 3, 2024

Is there anything left to do on this?

I unfortunately do not have a windows VM at the moment.

@jart jart closed this as completed in cf70a44 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted We intend to address this issue.
Projects
None yet
Development

No branches or pull requests

3 participants