Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redbean] OnServerHeartbeat() is broken in non-daemon mode #1173

Open
quantmage opened this issue May 7, 2024 · 0 comments
Open

[redbean] OnServerHeartbeat() is broken in non-daemon mode #1173

quantmage opened this issue May 7, 2024 · 0 comments

Comments

@quantmage
Copy link

First of all, thank you for the great library and its ongoing improvements! 👍

I noted an issue after I rebased my repo to 3.3.4 today. It turns out that OnServerHeartbeat() is not being called in the interactive (REPL) mode until a key input is given. I tracked it down to this change: 0e0398c#diff-a937cc5818818785e079eab14ff76fa5db080fe9bd902d1ab21aa546aa79c7d1R7153

Changing it back to EventLoop(100) (100ms timeout) fixed the problem for me. Was there any reason to change the poll timeout to -1 (i.e. no timeout)?

@quantmage quantmage changed the title [redbean] OnServerHeartbeat() is broken [redbean] OnServerHeartbeat() is broken in non-daemon mode May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant