-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDo List #135
Comments
Maybe make the web browser configurable? i.e. when you're on a system where your default browser is Firefox but you want to open bookmarks in Lynx because you're on a terminal anyway. Probably:
|
Try the
|
Does not work on Windows.
|
Not really a buku problem. A quick google search leads to http://stackoverflow.com/questions/25875093/how-to-set-browser-environmental-variable-for-python-webbrowser but I don't pay and use windows ;). So can't try it out myself. |
The last time I had to pay for Windows was in 2001. Later versions came preinstalled (for free) or over MSDNAA (for free) or as a free update (for free). I can confirm that the |
LoL!!! 👍 |
@jarun you should mark "Option to add folder names as tags while importing HTML" as done |
Done! |
|
|
It's be nice to have
These fields could also be used to retrieve or provide timestamps when importing and exporting browser bookmark files. The example file I was looking at had attributes for ADD_DATE and LAST_MODIFIED, but they were all the same (I assume the times represented correlate with the date/time the export created the file. |
@drbraden from the Introduction:
Please read it. It's there for a reason. |
Because there is no example of python script using buku, i write a simple script to print status code of saved url on buku. i'm not quite sure where to put it, so i put it here until there are more example script use grequest from https://github.com/kennethreitz/grequests import buku
import grequests
bdb = buku.BukuDb()
recs = bdb.get_rec_all()
recs[0]
# output: (1, 'example.com', 'example', 'tag1,tag2', 'page description', 0)
# Records have following structure:
# - id,
# - url,
# - metadata,
# - tags,
# - description,
# - flags
urls = [x[1] for x in recs]
rs = (grequests.get(u) for u in urls)
gr_results = grequests.map(rs)
for resp, url in zip(gr_results, urls):
stat_code = None if resp.status_code is None else resp.status_code
print('{}: {}'.format(stat_code, url))
# output
# 200: http://website1.com/
# None: http://website2.com/
# 200: http://website3.com/
# ... |
Very useful. Please add it under the |
I love Buku. What would you think about adding a field to the sqlite3 db for the text of the page? The page's text could be extracted while fetching the title, and all the html tags could be stripped off. It would then be available for searching. Example: There are several pages that I bookmark to read later or have already read, but the keyword I'm searching for isn't always contained in the title. And sometimes I can't enumerate every possible tag. If I could include the page's text in my search, then I could find my pages faster and easier. Is this too much for a bookmark manager? I know it would increase the size of the DB. |
Yes. You are asking for a local Google search engine. Search wouldn't remain a plaintext search anymore. The RoI isn't reasonable. |
Awesome work here! I'm starting up rely on this more and more, and I'm really amazed how feature rich this is already 👍 One thing I'd like to request, is a flag to specify the db location. I know that it looks in specific locations already - including local directory - but this would let me have multiple, completely separate sets of bookmarks (e.g. Work, personal, temporary/todo). I'm currently achieving this just fine with tags, but the option to logically separate them by file would be a great addition, especially for scripted scenarios. Thanks again for the great work here! |
@absolutejam Issue #171 was the same request. Though I am a bit reluctant, I think it's time to enable it based on public demand. ;) |
Suggested Feature. It would be really nice to have some way to a set of tags automatically assigned when one tag is assigned. Here are some example. I could tell buku that whenever I assign the tag "django", it should automatically assigns the tags "python" and "programming language" I could tell buku that whenever I assign the tag "iPhone" to an article, it automatically assigns the tags "Apple" and "Tech Companies" That way, you don't have to keep typing the list of tags every time. This is one of the main benefits of a folder-based bookmark manager. When you assign a bookmark to a folder, the parent folders are automatically associated with the bookmark. As a second idea, buku could suggest other tags based on your past bookmarks when you add a tag. |
Did you notice that tags can be set using simple redirection at the prompt?
Yes, but parsing/reading/writing to a filesystem numerous times is inherently slower than using a flat file. And listing tags would be scanning all those directories.
We can do this, suggest optionally. When a tag is added find other tags that go together and show the tag names + indices. User can use redirection at the prompt and add the tags. Would you be interested in contributing the feature? |
By redirection, do you mean the --tag flag? Would definitely like more clarity on this. I agree with point 2, which is why I do like tags better than folders. But a possible alternative is an single file with indented tags showing the hierarchical relationship between tags (ex. Company:Apple:iPhone). Then, when searching, you could have a strict search for the tags assigned to the bookmark only and a fuzzy search, which also includes bookmarks matching to parent or children tags with the results. Do like the sound of 3. Not sure if I would be able to contribute the feature (pretty novice programmer, so probably unlikely), but can always try to take a look. Two other questions: Can you add Markdown and URLs in comments field (Most concerned about using the # sign for headings)? Can comments from a bookmark or set of bookmarks be exported to a text file? Buku could be pretty useful for taking more detailed notes on the webpage you have bookmarked while reading them. |
No, I meant the smart tag editing with >>, > or << symbols at prompt.
The RoI isn't great.
You should if you really want it. I am not sure if I can get back to this.
You have to add a new filter to do that. Check option
You can add anything in a note. Try the |
Okay. Thanks. |
Hello! |
@alex-bender are you familiar with the Firefox and Chrome bookmark sqlite schema? If yes, you can check the |
I've checked Chrome bookmarks file. It's simple json. I don't know anything about FF, but let me check. |
@jarun Yeah, I found it. Are Buku/.github guides the only guides which I should follow? |
AFAIK the JSON file is the latest backup. Is the data same as that in the bookmark SQLite file?
Yep! |
Sorry but I can't find bookmark SQLite file for Chrome. But data in the Bookmark file are the same what I can see in my Bookmark Manager |
Please confirm if the data are same or not. Consider this scenario: you added a new bookmark in Chrome but didn't close the browser. Do you see that latest bookmark in the json file? |
Sorry for the mess. Here is what i've done:
Also, I've done what you asked, and result is positive: After adding a new bookmark it does appear in Bookmark file without closing the browser. |
Awesome! Then here's what we need to do - check the same with Firefox. If everything looks fine, add a new option to Buku to auto-import. We need to scan the usual locations (on Mac, Linux and Windows) for FF and Chrome. If any of them is not found, ask the user to specify the location of the file (for the specific browser) manually. |
Yeah, FF also updated bookmarks db without closing browser. |
Great! Waiting for your PR! 👍 |
@jarun hello, work is in progress, but you can comment anything you consider important here: |
@alex-bender thanks! I have reviewed.
If it gives you the installation location of the browser, go ahead. We already import it. Do you have anything else in mind? |
@rachmadaniHaryono please feel free to make the necessary changes and refactor. i will review in the PR. Please ensure you test the following cases:
Please use the bookmark paste I linked in the issue. |
@jarun Thanks for reviewing!
As far as I understand
I have a question according to the naming: should we check browsers like I'll implement rest (+tests, rebase\squash, docs) and will make PR. |
OK. I misunderstood earlier. Anyway, it would be local data so we have to check in default location ourselves.
I guess google chrome is sufficient as long as we provide the option to specify manually (documentation would play a really significant role in this feature). Every Google, Opera and Yandex has a fork of Chromium nowadays.
Does FF or GC show bookmarks from all profiles in the UI? If yes, we grab all! |
@jarun here is GC behavior: In my case two different profiles (chrome://settings/ People section) has different config folders |
Thanks! Here's what I think - if a user has 10 profiles all of the bookmarks belong to him. I think it's OK to import all the bookmarks. I think even when FF/GC is installed and it imports bookmarks from other browsers, it imports all profiles. Can you please verify this? |
By user above I meant OS user, not GC profile/user. |
But what if there are different profiles for different family members? In case when they are using single OS account (Like |
You are saying they are using the same login but Chrome is customized for each to have different profiles? Sorry, I think the idea is very far fetched and a big privacy issue. It's like two people using a single diary to write their journals. Anyway, what happens in the install -> auto import scenario? We can follow that. |
Ok, I'll check auto import scenario. |
From this discussion thread it seems like they only import from the default profile. We can do the same. |
No, I guess it's not absolute. |
I see here 3 options:
Of course first one is the simplest one. We can stick with it and see what'll happen next. |
Yes, let's go default. We'll document this under |
Please open a new issue for this. We can continue discussing there. I will roll this general discussion thread. |
Rolled at #174 |
Continued from #103.
Notes
The list below is a growing one. While suggesting new features please consider contributing to
Buku
. The code is intentionally kept simple and easy to understand with comments. We'll be happy to assist any new contributor. We need your help!Some of the fresh-baked features may not have been released yet. Grab the master branch for those.
Identified tasks
The text was updated successfully, but these errors were encountered: