Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bukuserver breaks with Werkzeug>1.0 #449

Closed
zoredache opened this issue Apr 27, 2020 · 4 comments
Closed

bukuserver breaks with Werkzeug>1.0 #449

zoredache opened this issue Apr 27, 2020 · 4 comments

Comments

@zoredache
Copy link

Bug reports

bukuserver breaks with Werkzeug>1.0

Short term I adjusted the bukuserver/requirements.txt to Werkzeug>=0.11.15,<1.0 on my local install, and installed using that requirements.

Error

# bukuserver 
Traceback (most recent call last):
  File "/usr/local/bin/bukuserver", line 5, in <module>
    from bukuserver.server import cli
  File "/usr/local/lib/python3.7/site-packages/bukuserver/server.py", line 17, in <module>
    from flask_reverse_proxy_fix.middleware import ReverseProxyPrefixFix
  File "/usr/local/lib/python3.7/site-packages/flask_reverse_proxy_fix/middleware/__init__.py", line 3, in <module>
    from werkzeug.contrib.fixers import ProxyFix
ModuleNotFoundError: No module named 'werkzeug.contrib'

Tested by doing a docker run --rm -it python:3.7-slim-buster and installing with pip install buku[server] and attempting to run with just a bukuserver run.

@jarun
Copy link
Owner

jarun commented Apr 27, 2020

Sorry, I am not aware of Werkzeug. Please fix it if you can and raise a PR.

@rachmadaniHaryono
Copy link
Collaborator

note that i already create pr for flask reverse proxy fix but it haven't been merged yet

antarctica/flask-reverse-proxy-fix#1

@jarun
Copy link
Owner

jarun commented Apr 30, 2020

I am closing this defect as it's not caused by Buku.

@jarun jarun closed this as completed Apr 30, 2020
@rachmadaniHaryono
Copy link
Collaborator

rachmadaniHaryono commented May 1, 2020

tldr for this issue

  • as op suggested: install Werkzeug>=0.11.15,<1.0 or
  • wait till this pr 1 accepted or
  • install from this branch 2

e: as of 2022 january 18 there is pr for this issue that will use fork of flask-reverse-proxy-fix , which contain fix for this 3

if this is working, above suggestion should not be needed anymore

Footnotes

  1. https://github.com/antarctica/flask-reverse-proxy-fix/pull/1

  2. https://github.com/rachmadaniHaryono/flask-reverse-proxy-fix/tree/feature/fix-import

  3. https://github.com/jarun/buku/pull/546

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants