Commit 31d5ac0
committed
Address additional Copilot AI feedback
1. Fix potential NullReferenceException in GetHashCode()
- Changed from CSharpType.GetHashCode() to HashCode.Combine(CSharpType)
- HashCode.Combine handles null values properly
2. Update CHANGELOG for accuracy
- Clarify that string/byte[] compare _maxWidthForStrings (backing field)
- Not the Width property which includes Size.ToStringLength()
- Add note about avoiding Size interference
- Mention null-safety improvement in GetHashCode()
- Update test count to 19 (added 2 edge case tests)
All 396 tests pass.1 parent 718c3ee commit 31d5ac0
2 files changed
+6
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| |||
0 commit comments