-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Zepto from the docs #2431
Comments
But the good news is that 1.0 has waaaay fewer failing tests with Zepto than 0.9.10 or 0.9.9 |
I was able to make the test suite pass with only minor changes to the test code (#2432). Closing this out in favor of the pull request. |
How about "Use at your own risk" -- explain that Zepto is an attempt to emulate the core jQuery API, but isn't 100% compatible. |
I think that's fine... My real concern is that if at some point in the future Zepto really ceases to be a viable option that it be removed from the docs. Just want to prevent giving people bad advice :) EDIT: apparently lodash isn't referenced in the docs anymore |
Here's what I'm currently thinking:
Something like:
|
Seems like we should assert something like:
I don't have any problem keeping Zepto in our current test suite, the question really is whether future maintenance will be necessary, and whether new tests will have to be written with Zepto in mind or whatever (and who will keep an eye out for that) |
@knowtheory +1 on that pass of the copy Part of the point of #2432 was to add the Zepto tests to the Travis build, to establish if it's responsible to say that it still "works" or not (and have a baseline for deciding whether or not it should be in the documentation as an optional jQuery replacement). If the final assessment is that we really don't want to expend the extra energy to support it, that's fine too. |
I was just going to open an issue about a Zepto inconsistency. // Remove this view by taking the element out of the DOM, and removing any
// applicable Backbone.Events listeners.
remove: function() {
this.$el.remove();
this.stopListening();
return this;
}, The problem is Zepto's |
@jdalton thanks, good catch. IMO more evidence for the "use at your own risk" line of reasoning... |
Now that the test suite isn't running against Zepto, perhaps we should drop the reference to it as an alternative DOM library from the docs (and note it in the changelog for 1.0).
If for whatever reason we'd like to keep it in the docs, there are a few ways to proceed as I see it:
delegateEvents
and 1 can be fixed directly in the test suite (it's relying on a:has
pseudo-selector, which Zepto chokes on.)So far, there are 3 projects in the examples section that use it: LinkedIn Mobile, Gilt Groupe, and Tzigla. Based on the relatively high profile of the first 2 names on that list, and the fact that it's still called out as a valid option in the docs, I think that something needs to be done.
(FWIW, I totally agree with the decision to drop support for it, I just don't want it to trip people up when it doesn't actually work.)
The text was updated successfully, but these errors were encountered: