Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router.navigate generated location.hash regression in 1.2 #4025

Closed
Flamefork opened this issue Apr 30, 2016 · 0 comments · Fixed by #4026
Closed

Router.navigate generated location.hash regression in 1.2 #4025

Flamefork opened this issue Apr 30, 2016 · 0 comments · Fixed by #4026

Comments

@Flamefork
Copy link
Contributor

Flamefork commented Apr 30, 2016 •
edited
Loading

This change 5821bc0 decodes the fragment, and the decoded value goes into location.hash, which makes URL effectively malformed.

Quick test to explain the problem:

Backbone.history.navigate('search/has%20space');
strictEqual(location.hash, '#search/has%20space');

Results:
before 5821bc0:
#search/has%20space
after:
#search/has space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed updating URL with uri-decoded value
1 participant
@Flamefork