Skip to content

Commit 640332b

Browse files
committed
Generalize _.sample over the collection types
1 parent d82eadc commit 640332b

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

modules/sample.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import isArrayLike from './_isArrayLike.js';
22
import clone from './clone.js';
3-
import values from './values.js';
3+
import toArray from './toArray.js';
44
import getLength from './_getLength.js';
55
import random from './random.js';
66
import times from './times.js';
@@ -10,7 +10,7 @@ import times from './times.js';
1010
// If **n** is not specified, returns a single random element.
1111
// The internal `guard` argument allows it to work with `_.map`.
1212
export default function sample(obj, n, guard) {
13-
var sample = isArrayLike(obj) ? null : values(obj);
13+
var sample = isArrayLike(obj) ? null : toArray(obj);
1414
obj = sample || obj;
1515
var length = getLength(obj);
1616
if (n == null || guard) return obj[random(length - 1)];

underscore-esm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

underscore-esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

underscore.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

underscore.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)