Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple uses of WalkthroughElement #6

Open
danielwinkler opened this issue Jan 14, 2020 · 2 comments
Open

Allow multiple uses of WalkthroughElement #6

danielwinkler opened this issue Jan 14, 2020 · 2 comments

Comments

@danielwinkler
Copy link

Hi @jasongaare ,

thanks for your nice lib!
I needed to revisit certain WalkthroughElement and provide a different content for it.
You can check my commit here, the code is actually quite straight forward
danielwinkler@a92c7aa

It will allow the following

export default [
  {
    id: 'profile-button',
    content: makeTooltipContent('Tap here to view a profile'),
  },
  {
    id: 'profile-name',
    content: makeTooltipContent("Here is the user's name"),
  },
  {
    id: 'profile-button',
    content: makeTooltipContent('Now tap again!'),
  },
];

I also changed the whole module to typescript, which allowed me to understand your implementation

Please let me know if you are interested in

  • this feature
  • the ts implementation

I would create proper pull request; (unfortunately the current commits don't properly show the differences i did to the file as the filename change from js to tsx at the same time :-(

@jasongaare
Copy link
Owner

Wow this is awesome! I am feeling guilty because I am jazzed about this lib and its potential, but just have not had the time to commit (no pun intended) to polishing it.

I would definitely be interested actually in both of those! Thanks for your work on this and your interest in this library

@danielwinkler
Copy link
Author

@jasongaare
great that you're interested;

I cleaned the history a bit so that it makes more sense.
#8 Adds all the typescript related stuff including tsdx, which should allow you to publish it without problems to npm
#7 Is the modification to allow multiple uses of the same Element

I separated the two, so you will get some merge conflicts, but given the simplicity of #7 I hope they shouldn't be a problem
Otherwise just let me know!

Cheers, Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants